You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ajax callback may happen after a widget dispose. If the callback has some dom action will occur some exceptions.
What if add a function to check whether originating component isfinalized? If the component's phase is finalized, then can just return from ajax callback rather than continue.
The text was updated successfully, but these errors were encountered:
This idea we talked before. Sometimes an AJAX request ('ajax' hub in troopjs) invokes from a widget. And most time the success callback is to do some dom actions. Consider that the ajax response is denied a couple of seconds and the widget has been disposed, and the callback is still going. Then it will cause an error on dom action.
Ah, so this is slightly different then, this ticket basically should be that we should check if the current component is in an allowed phase before triggering a callback (dom or hub).
In troopjs 2.x this already done for hubhere and here. I don't remember if this was implemented in 1.x.
I don't think that the same would be that hard to implement in 1.x, but before I look at that I just want to confirm that's what we want to do this (as I remember we discussed support for killing an ajax request at some other point).
Ajax callback may happen after a widget dispose. If the callback has some dom action will occur some exceptions.
What if add a function to check whether originating component is
finalized
? If the component's phase isfinalized
, then can just return from ajax callback rather than continue.The text was updated successfully, but these errors were encountered: