From faaed9eca71e108e02f623d8547e8ec04218617a Mon Sep 17 00:00:00 2001 From: David Murdoch Date: Thu, 22 Sep 2022 18:22:18 -0400 Subject: [PATCH] chore: remove support for Node.js v12 --- .github/workflows/pr.yml | 2 +- .github/workflows/push.yml | 2 +- .nvmrc | 2 +- CONTRIBUTING.md | 8 ++++---- package.json | 2 +- src/packages/ganache/README.md | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 1e3f464d9b..e1ad59f454 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -10,7 +10,7 @@ jobs: strategy: fail-fast: false matrix: - node: [12.0.0, 12.x, 14.x, 16.x, 18.x] + node: [14.0.0, 14.x, 16.x, 18.x] os: [windows-2019, ubuntu-18.04, ubuntu-20.04, macos-11] exclude: # Node v18 does not run on ubuntu-18.04: https://github.com/nodejs/node/issues/42351#issuecomment-1068424442 diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index 85365f63f7..a4f9bbe2ac 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -10,7 +10,7 @@ jobs: strategy: fail-fast: false matrix: - node: [12.0.0, 12.x, 14.x, 16.x, 18.x] + node: [14.0.0, 14.x, 16.x, 18.x] os: [ubuntu-20.04] runs-on: ${{ matrix.os }} diff --git a/.nvmrc b/.nvmrc index f04bd6da54..01f1a56f64 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v12.0.0 +v14.0.0 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3da36ea68d..6d5a456aed 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,11 +2,11 @@ ## Getting set up -- Use Node.js v12.0.0. - - Why v12.0.0? Because this is the first LTS release of Node.js v12 and is the earliest version Ganache supports. +- Use Node.js v14.0.0. + - Why v14.0.0? Because this is the first LTS release of Node.js v14 and is the earliest version Ganache supports. - recommendation: use [nvm](https://github.com/nvm-sh/nvm) on Linux and macOS, and [nvm-windows](https://github.com/coreybutler/nvm-windows) on Windows, to configure your node version. - - On Linux and macOS, if you have `nvm` installed, just run `nvm use` to switch to Node.js v12.0.0. + - On Linux and macOS, if you have `nvm` installed, just run `nvm use` to switch to Node.js v14.0.0. - `git clone git@github.com:trufflesuite/ganache.git` - `cd ganache` - `npm install` (use npm v6) @@ -153,7 +153,7 @@ index 2a2aa9e..57cbf21 100644 These are guidelines, not rules. :-) -- Use Node.js v12.0.0 for most local development. +- Use Node.js v14.0.0 for most local development. - Use `bigint` literals, e.g., `123n`; if the number is externally configurable and/or could exceed `Number.MAX_SAFE_INTEGER`. - Write tests. diff --git a/package.json b/package.json index 0e5970e5f9..d003c0eda8 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "author": "David Murdoch (https://davidmurdoch.com)", "private": true, "engines": { - "node": ">=12.0.0", + "node": ">=14.0.0", "npm": ">=6.12.0" }, "scripts": { diff --git a/src/packages/ganache/README.md b/src/packages/ganache/README.md index fa69202cfa..8a690c24b5 100644 --- a/src/packages/ganache/README.md +++ b/src/packages/ganache/README.md @@ -47,7 +47,7 @@ Ganache can be used from the [command line](#command-line-use), [programmaticall ### Command line use -You must first install [Node.js](https://nodejs.org/) >= v12.0.0 and npm >= 6.12.0. +You must first install [Node.js](https://nodejs.org/) >= v14.0.0 and npm >= 6.12.0. To install Ganache globally, run: