Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Ganache should update its CI dependencies #3835

Open
cds-amal opened this issue Oct 24, 2022 · 4 comments
Open

Ganache should update its CI dependencies #3835

cds-amal opened this issue Oct 24, 2022 · 4 comments

Comments

@cds-amal
Copy link
Member

Ganache has some deprecation warnings in CI.

See this run,,, click me. I submitted a PR to update most of the issues, but these two remaining ones touch on CI logic. The Ubuntu one may be easy as it is already excluded... but I could be misunderstanding things.

@davidmurdoch
Copy link
Member

Re set-output, we don't us it directly. I wonder where it is coming from.

Re ubuntu 18.04. We have a PR to fix it here #3405. It was previously blocked by Node v12 support.

@MicaiahReid
Copy link
Contributor

MicaiahReid commented Oct 25, 2022

@davidmurdoch we do use set-output for the new docker action for our releases. I didn't realize it was deprecated. Seems like it should be an easy fix to remove it.

@davidmurdoch
Copy link
Member

Ah, I'm working on branch that hasn't rebased to include the docker yaml stuff. Thanks for the correct!

@davidmurdoch davidmurdoch moved this to Inbox in Ganache Nov 17, 2022
@davidmurdoch davidmurdoch moved this from Inbox to Backlog in Ganache Nov 17, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants