You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Right now, when strictBooleans isn't turned on, the encoder allows arbitrary input for booleans. This is because ethers does and we wanted to be mostly compatible.
This behavior is kind of dangerous. It should only be allowed when there's no overloading to resolve (in internal terms, when the encoder is in loose mode -- which is not the same as having strictBooleans turned off).
The reason it works this way right now is because I implemented handling for booleans before we later had the idea of only allowing certain input in loose mode (something we presently do for integers). But we can apply that idea here too to make the encoder safer.
Environment
Truffle version (truffle version): 5.9.4
The text was updated successfully, but these errors were encountered:
Issue
Right now, when
strictBooleans
isn't turned on, the encoder allows arbitrary input for booleans. This is because ethers does and we wanted to be mostly compatible.This behavior is kind of dangerous. It should only be allowed when there's no overloading to resolve (in internal terms, when the encoder is in loose mode -- which is not the same as having
strictBooleans
turned off).The reason it works this way right now is because I implemented handling for booleans before we later had the idea of only allowing certain input in loose mode (something we presently do for integers). But we can apply that idea here too to make the encoder safer.
Environment
truffle version
): 5.9.4The text was updated successfully, but these errors were encountered: