Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Request and response size in bytes #3

Open
Chronojam opened this issue Feb 22, 2018 · 1 comment
Open

Request and response size in bytes #3

Chronojam opened this issue Feb 22, 2018 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@Chronojam
Copy link

Chronojam commented Feb 22, 2018 •
edited by timReynolds
Loading

It'd be great to have the payload size in bytes of traffic.

We could use it to detect malformed requests from upstream services
@timReynolds timReynolds changed the title request size in bytes Request and response size in bytes Feb 28, 2018
@timReynolds timReynolds added enhancement New feature or request question Further information is requested labels Feb 28, 2018
@timReynolds
Copy link
Contributor

I've got a few questions about this as I'm not convinced how useful it would be.

  1. What type of metric would you want this to be? Histogram? If so what should the bucket sizes be?
  2. What would the promQL metric for an alert look like? Given endpoints across a server can have very different characteristics and often driven by user input I'm unconvinced it would be meaningful.

Happy to be proven wrong about this so maybe adding it to an existing API using the exposed prom-client and feedback from there would be a good starting place.

@timReynolds timReynolds mentioned this issue Feb 28, 2018
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timReynolds @Chronojam