refactor: remove tsk_size_t (#507)

BREAKING CHANGE: Removed global constant from library

Author: molpopgen

src/lib.rs

@@ -101,7 +101,6 @@ pub mod types;
 mod util;
 
 use bindings::tsk_id_t;
-use bindings::tsk_size_t;
 
 // tskit defines this via a type cast
 // in a macro. bindgen thus misses it.

src/provenance.rs

@@ -13,7 +13,8 @@
 use crate::bindings as ll_bindings;
 use crate::sys;
 use crate::SizeType;
-use crate::{tsk_id_t, tsk_size_t, ProvenanceId};
+use crate::{tsk_id_t, ProvenanceId};
+use ll_bindings::tsk_size_t;
 
 #[derive(Eq, Debug)]
 /// Row of a [`ProvenanceTable`].

src/sys/mod.rs

@@ -319,7 +319,7 @@ fn tsk_column_access_detail<R: Into<bindings::tsk_id_t>, L: Into<bindings::tsk_s
 ) -> Option<T> {
     let row = row.into();
     let column_length = column_length.into();
-    if row < 0 || (row as crate::tsk_size_t) >= column_length {
+    if row < 0 || (row as crate::sys::bindings::tsk_size_t) >= column_length {
         None
     } else {
         assert!(!column.is_null());

src/table_collection.rs

@@ -3,6 +3,7 @@ use std::vec;
 
 use crate::bindings as ll_bindings;
 use crate::error::TskitError;
+use crate::tsk_id_t;
 use crate::types::Bookmark;
 use crate::IndividualTableSortOptions;
 use crate::Position;
@@ -14,8 +15,8 @@ use crate::TableOutputOptions;
 use crate::TableSortOptions;
 use crate::TreeSequenceFlags;
 use crate::TskReturnValue;
-use crate::{tsk_id_t, tsk_size_t};
 use crate::{EdgeId, NodeId};
+use ll_bindings::tsk_size_t;
 use ll_bindings::tsk_table_collection_free;
 use mbox::MBox;
 

src/tree_interface.rs

@@ -1,13 +1,13 @@
 use crate::bindings as ll_bindings;
 use crate::sys;
 use crate::tsk_id_t;
-use crate::tsk_size_t;
 use crate::NodeId;
 use crate::Position;
 use crate::SizeType;
 use crate::Time;
 use crate::TreeFlags;
 use crate::TskitError;
+use ll_bindings::tsk_size_t;
 use std::ptr::NonNull;
 
 pub struct TreeInterface {