Skip to content

change num_ to n_ in ts.pca? #3101

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
petrelharp opened this issue Mar 13, 2025 · 2 comments
Closed

change num_ to n_ in ts.pca? #3101

petrelharp opened this issue Mar 13, 2025 · 2 comments

Comments

@petrelharp
Copy link
Contributor

As discussed in #3008, elsewhere in tskit we do n_X; but in ts.pca we have num_oversamples and num_components. The latter matches scikit-learn, but I'm voting for internal consistency in tskit.

@jeromekelleher
Copy link
Member

+1 for internal consistency. We can add synonyms later for compatibility with other libraries if its useful

@petrelharp
Copy link
Contributor Author

And, I got this backwards. Elsewhere in tskit we do num_X.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants