Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Emojify reactions #186

Closed
n-peugnet opened this issue Jun 30, 2020 · 3 comments
Closed

Emojify reactions #186

n-peugnet opened this issue Jun 30, 2020 · 3 comments

Comments

@n-peugnet
Copy link
Contributor

I don't know how Matrix reactions really work, but I suppose that to send emoji reactions, we just have to put its unicode tag in the content of the reaction. As #65 has been merged, I guess we could reuse the emoji.Sprint(text) function for this task. I looked a little bit at the code and identified some functions where to put It, but I don't really know which one would be the best:

func cmdReact(cmd *Command) {

func (view *RoomView) SendReaction(eventID id.EventID, reaction string) {

I am not really used to go and I do not manage to make the app built from source work correctly alongside the packaged one, so I would prefer not to make the change myself.

@tulir
Copy link
Owner

tulir commented Jun 30, 2020

You can already just autocomplete emojis, but if someone wants to make a PR that makes /react optionally (either the existing disable_emojis option or a new one) use emoji.Sprint, I'd probably accept it.

@n-peugnet
Copy link
Contributor Author

I didn't know it was possible 😆 ! I just tried to hit tab and it worked as expected. I will add it to the wiki.

@tulir
Copy link
Owner

tulir commented Apr 15, 2022

This was added in #354

@tulir tulir closed this as completed Apr 15, 2022
Repository owner locked and limited conversation to collaborators Nov 10, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants