Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replacing emoji descriptions with their emojis #61

Closed
jcgruenhage opened this issue Jun 11, 2018 · 4 comments
Closed

Replacing emoji descriptions with their emojis #61

jcgruenhage opened this issue Jun 11, 2018 · 4 comments
Labels
easy Good for newcomers enhancement New feature or request
Milestone

Comments

@jcgruenhage
Copy link
Contributor

Going from :tada: to 🎉 and things like that.

While we're talking about emojis, since some terminals/fonts don't properly support them, going the other way around would be nice too

@tulir
Copy link
Owner

tulir commented Jun 11, 2018

https://github.com/kyokomi/generateEmojiCodeMap might be useful, it can create a text -> emoji mapping like this. Alternatively, the data in https://github.com/github/gemoji can be used directly

@tulir tulir added enhancement New feature or request easy Good for newcomers labels Jun 11, 2018
@jcgruenhage
Copy link
Contributor Author

the text mapping looks like it should get the job done

It would (for performance) probably be best to try to find the relevant parts in the messages with a regex and then map them to their emoji counterparts using that map. Having an inverse map for displaying the text representations shouldn't be too hard. Thanks for doing the quick research on it!

@vn-ki
Copy link
Contributor

vn-ki commented Jun 30, 2018

I am looking into this issue currently.

Can we use kyokomi/emoji directly inside gomuks? I believe that would make this issue very easy.

@tulir
Copy link
Owner

tulir commented Jun 30, 2018

The Sprint function of that library can be used directly, but a new function is probably needed for the emoji->text conversion (for terminals/fonts that don't support emoji properly).

@vn-ki vn-ki mentioned this issue Jun 30, 2018
@tulir tulir closed this as completed in #65 Jul 2, 2018
@tulir tulir added this to the 0.1.0 milestone Mar 28, 2019
Repository owner locked and limited conversation to collaborators Nov 10, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
easy Good for newcomers enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants