Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

TypeScript version upgrade blocked #459

Open
BurtHarris opened this issue Apr 16, 2020 · 2 comments · May be fixed by #454
Open

TypeScript version upgrade blocked #459

BurtHarris opened this issue Apr 16, 2020 · 2 comments · May be fixed by #454
Labels
in progress pull request

Comments

@BurtHarris
Copy link
Collaborator

BurtHarris commented Apr 16, 2020 •
edited
Loading

Strange error behavior if we upgrade to TypeScript version 3. The tsc command seems to hang or become very slow.
@viceice viceice mentioned this issue Apr 16, 2020
Closed
@BurtHarris
Copy link
Collaborator Author

BurtHarris commented Apr 18, 2020 •
edited
Loading

In this context, I've isolated the problem to benchmark/TestPerformance.ts, the way this code is structured is giving tsc fits. Sometimes I see error messages that say something to the effect of ... comparing JavaParser to JavaParser, which gave me a clue. There are 4 or 5 different JavaParsers involved, leading me to suspect this line of code, just after the imports:

 type AnyJavaParser = JavaParser | JavaParserAtn | JavaLRParser | JavaLRParserAtn | ParserInterpreter;

I have a fix pending which simplifies cases where JavaParser | JavaParserAtn | JavaLRParser | JavaLRParserAtn gets replaced with a very simple IJavaParser interface, in the above line and elsewhere. Compiler no longer hangs.

@BurtHarris BurtHarris linked a pull request Apr 26, 2020 that will close this issue
Open
@BurtHarris BurtHarris linked a pull request Apr 26, 2020 that will close this issue
chore: Build update #454
Open
@volkanunsal
Copy link

It would be great to see this PR merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
in progress pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Build update
2 participants
@volkanunsal @BurtHarris