Skip to content
This repository has been archived by the owner on Jul 28, 2018. It is now read-only.

Would be possible to set request_method to be a session cookie? #641

Open
ivanxuu opened this issue Dec 1, 2015 · 0 comments
Open

Would be possible to set request_method to be a session cookie? #641

ivanxuu opened this issue Dec 1, 2015 · 0 comments

Comments

@ivanxuu
Copy link

ivanxuu commented Dec 1, 2015

Method popCookie in turbolinks.js.coffee sets the cookie to expire in 1970, so this sets this cookie to never expire.

document.cookie = name + '=; expires=Thu, 01-Jan-70 00:00:01 GMT; path=/'

If the expires section is omitted, the 'immortal' cookie becames a session cookie, so it will be erased when the browser is closed.

document.cookie = name + '=; path=/'

Is there any reason to not use a session cookie instead?

Thanks

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant