Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Spin Icon customization ,And provide the v-loading instruction modifier #260

Closed
jahnli opened this issue Jun 23, 2021 · 7 comments · Fixed by #289
Closed

Spin Icon customization ,And provide the v-loading instruction modifier #260

jahnli opened this issue Jun 23, 2021 · 7 comments · Fixed by #289
Assignees
Labels
feature request New feature or request

Comments

@jahnli
Copy link
Collaborator

jahnli commented Jun 23, 2021

This function solves the problem (这个功能解决的问题)

Using complex

Expected API (期望的 API)

Icon customization ,And provide the v-loading instruction modifier

@07akioni 07akioni added the feature request New feature or request label Jun 23, 2021
@07akioni
Copy link
Collaborator

We may provide a customization slot for spin.

@07akioni
Copy link
Collaborator

We won't provide a directive such a v-loading.

@Fnzero Fnzero linked a pull request Jun 24, 2021 that will close this issue
@cisolarix
Copy link
Contributor

@07akioni 请问一下,不提供 v-loading 指令,是基于什么考虑呢?

@07akioni
Copy link
Collaborator

@07akioni 请问一下,不提供 v-loading 指令,是基于什么考虑呢?

非组件化的东西很难支持主题,这个库尽量把功能通过组件化的方式提供。

@yuntian001
Copy link

yuntian001 commented Apr 18, 2022

v-loading是非常实用的,强烈建议加上,主题更改v-loading的样式用css解决就好了,或者v-loading部分自己用style传参方式自定义主题支持就好了,没有必要为了主题 而全部用组件化,建议做一些取舍。 @07akioni

@liu-xinhui
Copy link

用这种ui库的基本都是后台项目,90%的后台项目都不会做主题更改,所以为了这么个主题功能让功能变得不易用,不值得

@wcldyx
Copy link

wcldyx commented Jun 17, 2024

v-loading是非常实用的,强烈建议加上,主题更改v-loading的样式用css解决就好了,或者v-loading部分自己用style传参方式自定义主题支持就好了,没有必要为了主题 而全部用组件化,建议做一些取舍。 @07akioni

非常赞同

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants