Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Feature]: allow peer dep of typescript v5 #497

Open
osdiab opened this issue Nov 7, 2023 · 2 comments · May be fixed by #498
Open

[Feature]: allow peer dep of typescript v5 #497

osdiab opened this issue Nov 7, 2023 · 2 comments · May be fixed by #498
Labels
🛑 Abandoned The issue or Pull Request will not be worked on ✨ Feature Request Something should be added

Comments

@osdiab
Copy link

osdiab commented Nov 7, 2023

Describe the problem

@twind/core right now has a peer dependency requirement of typescript@^4, but typescript v5 has been out for a while, so adding this package also causes there to be peer dependency errors because i use the newer version of typescript

Describe the proposed solution

more permissive peer dep version for typescript, e.g. >4 or ^4 || ^5

Alternatives considered

No response

Importance

nice to have

Additional Information

No response
@osdiab osdiab added the ✨ Feature Request Something should be added label Nov 7, 2023
@osdiab osdiab linked a pull request Nov 7, 2023 that will close this issue
Open
5 tasks
@AndreLeifert
Copy link

not just @twind/core - presets, too

@kasvith
Copy link

kasvith commented Apr 3, 2024

Hi im facing the same issue with peerDeps

@AlexanderArvidsson AlexanderArvidsson mentioned this issue Jul 19, 2024
Open
@stale stale bot added the 🛑 Abandoned The issue or Pull Request will not be worked on label Dec 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
🛑 Abandoned The issue or Pull Request will not be worked on ✨ Feature Request Something should be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow typescript v5 osdiab/twind
3 participants
@osdiab @AndreLeifert @kasvith