Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve burger menu #24205

Closed
ghost opened this issue Oct 2, 2017 · 4 comments
Closed

Improve burger menu #24205

ghost opened this issue Oct 2, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 2, 2017

Hi,

Today, I used Bootstrap v4 alpha 6 and wanted to change color of burger menu (3 lines).
But I discovered that burger menu was a button which contained a span with a background-image.

This background-image is an SVG.. So developers can not change color...

I think it would be a good idea to:

FIRSTLY, change svg to three span to enable developers to modify burger menu color.

SECONDLY, in full css (keyframes) and/or with javascript/jquery, propose few animations like these codepen examples:

https://codepen.io/designcouch/pen/Atyop

Thanks!

@mdo
Copy link
Member

mdo commented Oct 2, 2017

You can customize the navbar toggler icon via Sass by changing the $navbar-dark-color or $navbar-light-color, which is used to generate the color on the SVG.

@mdo mdo closed this as completed Oct 2, 2017
@fuzzy76
Copy link

fuzzy76 commented Dec 18, 2017

Which essentially means bootstrap isn't usable for dark backgrounds without compiling your own? :(

@mdo
Copy link
Member

mdo commented Dec 19, 2017

I mean you can jump to that conclusion, or you can take a look at the source code, issues, and PRs that led to the code's current status and provide more valuable feedback in the form of suggested changes.

That said, I imagine you would need to recompile everything to build a completely dark site. Bootstrap's variables are setup to support that—it's why we extend the $body-bg and $body-color variables into other components. I wouldn't advice adding onto Bootstrap's compiled CSS for such a change.

@fuzzy76
Copy link

fuzzy76 commented Dec 20, 2017

I get that you have to make decisions balancing features against each other. The problem now is that a lot of components has -dark variants for their classes which gets you almost all the way towards a dark page straight from a CDN bootstrap. The hamburger menu is the only component I've noticed so far that breaks it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants