Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Gate (at least) Bash support behind a feature flag #710

Closed
Xophmeister opened this issue Jul 3, 2024 · 0 comments · Fixed by #711
Closed

Gate (at least) Bash support behind a feature flag #710

Xophmeister opened this issue Jul 3, 2024 · 0 comments · Fixed by #711

Comments

@Xophmeister
Copy link
Member

Is your feature request related to a problem? Please describe.
We have seen a number of times that building tree-sitter-bash fails as it references a (somehow) invalid ref on Savannah (GNU's git service, which hosts the Bash repository). The offending commit does appear to exist, so it's not clear why this occurs.

In the past, we've managed to resolve this by bumping the tree-sitter-bash version. However, IIRC, we have reached the point where this is no longer possible; newer versions use TS 0.21 (see #684). It's therefore possible that this problem could reoccur and there'd be no simple fix.

Describe the solution you'd like
Put Bash support behind a feature gate, which is disabled by default.

Describe alternatives you've considered
Remove Bash support completely, until we can move to a newer version.

Additional context
topiary-queries already uses feature flags; I believe we'd just have to remove Bash from the default features to achieve this.

We're singling out Bash because it is unstable, but perhaps there is also an argument to be had for gating all experimental languages behind an off-by-default feature flag.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant