Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: RequestValidator to use getRawPath, getRawQuery() and getRawFragment() #823

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: RequestValidator to use getRawPath, getRawQuery() and getRawFragment() #823

wants to merge 2 commits into from

Conversation

bhaskar16
Copy link

Fixes #601

Closes #601

This PR changes the RequestValidator's updatePort() method to use the raw implementations for Path, Query and Fragment which helps in better sanitisation of urls.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@bhaskar16
Copy link
Author

@Bazzooka1972 Could you tell me how to ensure that the tests run? I would like to merge this when I can.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Bazzooka1972 Bazzooka1972 Bazzooka1972 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestValidator.validate incorrectly decodes query string when removing port
2 participants
@bhaskar16 @Bazzooka1972