Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

Restructure java targets to be 1-1-1. #385

Open
jsirois opened this issue Jun 16, 2015 · 0 comments
Open

Restructure java targets to be 1-1-1. #385

jsirois opened this issue Jun 16, 2015 · 0 comments

Comments

@jsirois
Copy link
Contributor

jsirois commented Jun 16, 2015

Today there are many java BUILD targets that are subsets of a package. To maintain the BUILD files for these targets in a reasonable way, constant lists of source files are defined that can be subtracted out from target sources lists using the globs exclude facility. At some point pants will likely remove the ability to define constants in BUILD files and this mode of defining non 1-1-1 targets will be taken away, forcing duplication of file lists and the associated maintenance risk.

There are 2 complicating factors here:

  1. re-packaging will likely break clients of the java jars - they'll need to fix imports; so, this will require a deprecation cycle
  2. IIUC the official home for the java code is still inside Twitter walls; so, this refactoring really needs to occur in Twitter's repo and then be synced out here.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant