Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Scala 3 support #932

Open
pjfanning opened this issue Jun 22, 2022 · 3 comments
Open

Scala 3 support #932

pjfanning opened this issue Jun 22, 2022 · 3 comments

Comments

@pjfanning
Copy link

pjfanning commented Jun 22, 2022

Is your feature request related to a problem? Please describe.

I'm not really a Finagle user but maintain jackson-module-scala. Finagle does not yet support Scala 3 but many of its dependencies do. I'm just opening this issue for discussion purposes.

A few twitter util jars are not supported - see twitter/util#274 (comment)

For Scala 3, this class will need to change to use jackson-module-scala ClassTagExtensions instead of ScalaObjectMapper.

https://github.com/twitter/finagle/blob/develop/finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Value.scala

In theory, you could keep using ScalaObjectMapper for Scala 2 builds. This class is deprecated but there are no plans to remove it from jackson-module-scala 2.x (but it will probably not be part of jackson-module-scala 3.x - the v3.x release is not yet planned and is not worth worrying about yet).

Describe the solution you'd like

Generally, it would be nice to get everyone onto Scala 3.

@ghost
Copy link

ghost commented Jul 5, 2022

scala 3 is good so far indeed

@hartmut27
Copy link

hartmut27 commented Aug 24, 2022

a cross compile works with Finagle and Scala 3, with the help of ... CrossVersion.for3Use2_13.

build.sbt:

libraryDependencies += "com.twitter" %% "util-core" % "22.12.0" cross CrossVersion.for3Use2_13,
libraryDependencies += "com.twitter" %% "finagle-http" % "22.12.0" cross CrossVersion.for3Use2_13,
libraryDependencies += "com.twitter" %% "finagle-core" % "22.12.0" cross CrossVersion.for3Use2_13,

to identify all transitive dependencies and their versions, this can help

$ sbt dependencyTree

@xin301x
Copy link

xin301x commented Oct 11, 2022 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

3 participants