Fixes for Volume Profile

[delicateear]

Divide bins evenly by price if sort_close. Fixes #318

Positive and negative volume based on price direction, not volume direction. Fixes #319

Minor refactoring for clarity.

[twopirllc]

It all looks good and the fixes are welcome 😄.

I only suggest not changing lines 23-27 since some may pass in a different source for whatever reason.

[delicateear]

Aha, thanks for the observation; I did not realize what was going on with the Series names. Fixed.

I also updated the docstring. User jeichenseerNRX is also me - I need to sort out my SSH keys. = /

[twopirllc]

@delicateear,

Aha, thanks for the observation; I did not realize what was going on with the Series names. Fixed.
I also updated the docstring. User jeichenseerNRX is also me - I need to sort out my SSH keys. = /

No worries. Thanks for improving vp promptly. 😎 I will roll it into the development branch soon and let you know when it's ready to check out before I push it to main.

Thanks,
KJ

[twopirllc]

Hello @delicateear,

I pushed it to the development branch if you want to check it out before it's pushed to main.

$ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development

Thanks for the contribution. 😎

KJ

[delicateear]

Looks good to me. 👍🏾
jhno

[twopirllc]

@delicateear,

Thank you Sir.

KJ