Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Slot to timestamp mapping matches public explorers #101

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

scarmuega
Copy link
Member

@scarmuega scarmuega commented Jan 25, 2022

This PR fixes the mapping of slot => timestamp described in #50 and prepares the groundwork to introduce other more-robust strategies to allow multi-era timestamp calculation (for example, using state query mini-protocol on N2C scenarios)

@scarmuega scarmuega marked this pull request as ready for review January 25, 2022 23:41
@scarmuega scarmuega added this to the v1.1 milestone Jan 25, 2022
@mark-stopka mark-stopka self-requested a review January 25, 2022 23:53
@mark-stopka mark-stopka added the enhancement New feature or request label Jan 25, 2022
@mark-stopka mark-stopka linked an issue Jan 25, 2022 that may be closed by this pull request
Copy link
Collaborator

@mark-stopka mark-stopka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-stopka mark-stopka merged commit 876ac56 into main Jan 25, 2022
@mark-stopka mark-stopka deleted the fix/timestamps branch January 26, 2022 00:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug: Timestamp is 19 seconds off
2 participants