You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The task is to remove the servant-auth dependency while keeping the current behavior. The functionality seems simple enough that we can implement it without any additional dependencies. But, if an existing library arises that fits the task well, I am not against using it.
The text was updated successfully, but these errors were encountered:
Currently, we abuse the
servant-auth
library to provide authentication for octo CLI.The authentication is very simple: we just check the
Authorization
header in every request for equality.Using
servant-auth
for this is overkill and the library doesn't handle the use case very well – it expects the payload to be JSON-encoded, etc.Additionally, it has a large dependency footprint that we can avoid.
octopod/octopod-api/src/Octopod/PowerAPI.hs
Line 77 in 90fa7b8
octopod/octopod-api/src/Octopod/PowerAPI.hs
Line 49 in 90fa7b8
octopod/octopod-backend/src/Octopod/PowerAPI/Auth/Server.hs
Lines 14 to 23 in 90fa7b8
octopod/octo-cli/src/Octopod/PowerAPI/Auth/Client.hs
Lines 15 to 28 in 90fa7b8
The task is to remove the
servant-auth
dependency while keeping the current behavior. The functionality seems simple enough that we can implement it without any additional dependencies. But, if an existing library arises that fits the task well, I am not against using it.The text was updated successfully, but these errors were encountered: