New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ApplicativeError final example - raiseError ignored #4045

Closed

steve-e opened this issue Nov 17, 2021 · 0 comments · Fixed by #4046

Contributor

steve-e commented Nov 17, 2021

The final example for ApplicativeError is wrong IMO. It calls raiseError but the result is ignored.

def getTemperatureFromByCoordinatesAlternate[F[_]](x: (Int, Int))(implicit me: MonadError[F, String]): F[Int] = {
  if (x._1 < 0 || x._2 < 0) me.raiseError("Invalid Coordinates")
  for { c <- getCityClosestToCoordinate[F](x)
        t <- getTemperatureByCity[F](c) } yield t
}

Discussed briefly on gitter. Its just missing an else statement. Will create a PR referencing this issue

The text was updated successfully, but these errors were encountered:

steve-e mentioned this issue

4045 Add missing else keyword to example #4046

Merged

rossabaker closed this as completed in #4046

# for free to join this conversation on GitHub. Already have an account? # to comment