Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unused imports are not reported in 2.13.2 #22

Closed
GuillaumeSaintRaymondSonos opened this issue Jun 5, 2020 · 5 comments
Closed

Unused imports are not reported in 2.13.2 #22

GuillaumeSaintRaymondSonos opened this issue Jun 5, 2020 · 5 comments

Comments

@GuillaumeSaintRaymondSonos

Works great with Scala 2.13.1, tried with last version 0.1.12.
Is this something known ?
I see that on the README, it's tested only with 2.13.1

@SethTisue
Copy link
Member

it appears from https://github.com/DavidGregory084/sbt-tpolecat/blob/master/src/main/scala/io/github/davidgregory084/TpolecatPlugin.scala that the plugin does enable -Wunused:imports

Not sure, but perhaps it's something specific to your code (and perhaps ultimately there's a scalac bug involved). Attempting to isolate the problem would resolve the question one way or the other.

@GuillaumeSaintRaymondSonos
Copy link
Author

Thanks for the response, I managed to reproduce the problem with a simple project https://github.com/GuillaumeSaintRaymondSonos/sbt-tpolecat-circe/

By default, unused warning reporting is working well with Scala 2.13.2 but when I add circe dependency and after adding a scalac option for @JsonCodec. This is where the behaviour is different between 2.13.1/2.13.2

@SethTisue
Copy link
Member

SethTisue commented Jun 9, 2020

sounds like not a problem in this repo, then. sounds to me like you should try circe issue tracker next, if the problem isn't reproducible without circe.

I wonder if it's related to scala/scala#8799

if you're really determined to track this down, one path forward would be to use git bisect or https://github.com/adriaanm/binfu/blob/master/bisect.sh to pinpoint the exact scala/scala PR when this regressed (and/or just browse all the merged 2.13.2 PRs yourself)

@GuillaumeSaintRaymondSonos
Copy link
Author

All good, thx a lot ! Will close the ticket here.

@GuillaumeSaintRaymondSonos
Copy link
Author

Scala 2.13.3 fixed the issue !

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants