Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(app): add footer #375

Merged
merged 5 commits into from
Dec 5, 2022
Merged

feat(app): add footer #375

merged 5 commits into from
Dec 5, 2022

Conversation

xStrixU
Copy link
Contributor

@xStrixU xStrixU commented Dec 5, 2022

Fixes #362

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devfaq ✅ Ready (Inspect) Visit Preview Dec 5, 2022 at 3:53PM (UTC)

Copy link
Member

@typeofweb typeofweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Na mobile linki nie są na środku.
Na desktopie nie ma paddingu z prawej strony.

href="https://www.facebook.com/DevFAQ"
target="_blank"
rel="noreferrer"
className={LINK_CLASS_NAME}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jaki jest powód, że akurat te dwa linki chowamy na mobile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tak było na starym DevFAQ, że tylko dwa linki zostawały na mobile:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, ale może nie musi tak być? Może powinniśmy złamać ten wiersz jeśli linki się nie mieszczą?

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…2-footer
@typeofweb
Copy link
Member

Już jest container

@typeofweb typeofweb merged commit 9a522ff into develop Dec 5, 2022
@typeofweb typeofweb deleted the 362-footer branch December 5, 2022 21:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer
2 participants