feat(app): add modal to add question #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
typeofweb
requested changes
Dec 8, 2022
|
|
||
| export const AddQuestionModal = (props: ComponentProps<typeof BaseModal>) => ( | ||
| <BaseModal {...props}> | ||
| <h3 className="text-center text-xl font-bold uppercase text-primary">Nowe pytanie</h3> |
There was a problem hiding this comment.
Suggested change
| <h3 className="text-center text-xl font-bold uppercase text-primary">Nowe pytanie</h3> | |
| <h2 className="text-center text-xl font-bold uppercase text-primary">Nowe pytanie</h2> |
|
|
||
| export const AddQuestionModal = (props: ComponentProps<typeof BaseModal>) => ( | ||
| <BaseModal {...props}> | ||
| <h3 className="text-center text-xl font-bold uppercase text-primary">Nowe pytanie</h3> |
There was a problem hiding this comment.
Brakuje jakiegoś elementu form nad tym
| <option>HTML5</option> | ||
| <option>JavaScript</option> | ||
| </Select> | ||
| <Select className="w-full"> |
| <option>Wybierz Poziom</option> | ||
| <option>junior</option> | ||
| <option>Mid</option> | ||
| <option>Senior</option> |
|
|
||
| export const BaseModal = ({ isOpen, onClose, children }: BaseModalProps) => { | ||
| useEffect(() => { | ||
| isOpen && lockScroll(); |
There was a problem hiding this comment.
Suggested change
| isOpen && lockScroll(); | |
| if (isOpen) { | |
| lockScroll(); | |
| } |
There was a problem hiding this comment.
Nie brakuje tu else z unlockScroll ?
| > | ||
| <div | ||
| className="relative h-full w-full max-w-3xl animate-show rounded-sm bg-white px-3.5 py-9 sm:h-fit sm:px-11 sm:py-20" | ||
| onClick={(event) => event.stopPropagation()} |
|
|
||
| export const Select = ({ className, ...props }: SelectHTMLAttributes<HTMLSelectElement>) => ( | ||
| <select | ||
| className={twMerge( |
There was a problem hiding this comment.
Te zaokrąglone brzegi wyglądają średnio:
| }, []); | ||
|
|
||
| return ( | ||
| <ModalContextProvider value={{ openedModal, openModal, closeModal }}> |
There was a problem hiding this comment.
Tutaj tworzy się nowy obiekt przy każdym renderze i powoduje to, że cały kontekst się przerenderowuje. Brakuje useMemo
apps/app/tailwind.config.js
Outdated
Comment on lines
42
to
49
| backgroundImage: { | ||
| "select-purple": 'url("/select-purple.svg")', | ||
| }, | ||
| backgroundSize: { | ||
| "select-purple": "25px", | ||
| }, | ||
| backgroundPosition: { | ||
| "select-purple": "100% 50%", |
There was a problem hiding this comment.
Można po prostu dopisać klasę do pliku tailwind.css :)
typeofweb
reviewed
Dec 8, 2022
Comment on lines
30
to
32
| afterLeave={() => { | ||
| unlockScroll(); | ||
| }} |
There was a problem hiding this comment.
Suggested change
| afterLeave={() => { | |
| unlockScroll(); | |
| }} | |
| afterLeave={unlockScroll} |
typeofweb
requested changes
Dec 8, 2022
| > | ||
| <div | ||
| className="relative h-full w-full max-w-3xl animate-show rounded-sm bg-white px-3.5 py-9 sm:h-fit sm:px-11 sm:py-20" | ||
| onClick={(event) => event.stopPropagation()} | ||
| onClick={(event) => { | ||
| // stop triggering click event to higher component |
There was a problem hiding this comment.
Suggested change
| // stop triggering click event to higher component | |
| // stop propagation to avoid triggering `onClick` on the backdrop behind the modal |
| @@ -4,7 +4,7 @@ import type { SelectHTMLAttributes } from "react"; | |||
| export const Select = ({ className, ...props }: SelectHTMLAttributes<HTMLSelectElement>) => ( | |||
| <select | |||
| className={twMerge( | |||
| "cursor-pointer appearance-none border-b border-primary bg-select-purple bg-no-repeat py-2 pr-6 pl-1 text-sm capitalize text-primary transition-shadow duration-100 focus:shadow-[0_0_10px] focus:shadow-primary focus:outline-0", | |||
| "select-purple cursor-pointer appearance-none rounded-none border-b border-primary py-2 pr-6 pl-1 text-base capitalize text-primary transition-shadow duration-100 focus:shadow-[0_0_10px] focus:shadow-primary focus:outline-0", | |||
typeofweb
approved these changes
Dec 8, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.