Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(app): fix login page styles #450

Merged
merged 4 commits into from
Dec 20, 2022
Merged

fix(app): fix login page styles #450

merged 4 commits into from
Dec 20, 2022

Conversation

grzegorzpokorski
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devfaq ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 10:38PM (UTC)

@github-actions
Copy link

github-actions bot commented Dec 20, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 79.74 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-7fyjtqffe-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@typeofweb
Copy link
Member

Co ma robić ten PR?
Na pewno wygląda gorzej na mobile.

@grzegorzpokorski
Copy link
Member Author

Przed zmianami:

przed-zmianami-w-tym-pr

przed-zmianami-w-tym-pr-2

Po zmianach:

po-zmianach

po-zmianach-2

@grzegorzpokorski
Copy link
Member Author

@mmiszy, opisz proszę co poprawić, co wygląda gorzej / źle to od razu poprawie :)

@typeofweb
Copy link
Member

066857C9-2228-4DA7-9511-76FA458C6B30
Po zmianach:
5BC4498C-5CF1-4D13-8B66-B141C79EC2A8

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-larg9e4ke-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@grzegorzpokorski
Copy link
Member Author

Jeśli chodzi o zmiany to obejmowały one:

  • wycentrowanie treści w pionie,
  • naprawa fioletowego tła, aby pokrywało całą stronę, a nie tylko viewport.

@grzegorzpokorski
Copy link
Member Author

@mmiszy, czyli uważasz, że lepiej będzie na sztywno przykleić w pewnej odległości od góry całą treść?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-77mdsjfcp-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@grzegorzpokorski
Copy link
Member Author

Dobra już wiem mniej więcej gdzie może leżeć problem, dlaczego na mobilnych przeglądarkach zmiany mogą wyglądać kiepsko: (https://stackoverflow.com/questions/37112218/css3-100vh-not-constant-in-mobile-browser). Spróbuję to poprawić, a jak się nie uda to odpuszczę centrowanie treści w pionie.

@grzegorzpokorski
Copy link
Member Author

Przy okazji można się dowiedzieć o nowych jednostkach w css: https://web.dev/viewport-units/

@grzegorzpokorski grzegorzpokorski marked this pull request as draft December 20, 2022 22:23
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-7ut3ptc94-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@grzegorzpokorski
Copy link
Member Author

grzegorzpokorski commented Dec 20, 2022

@mmiszy, w wolnej chwili proszę przetestuj jak wygląda teraz strona po zmianie na safari na telefonie i daj znać co o tym sądzisz.

@grzegorzpokorski grzegorzpokorski marked this pull request as ready for review December 20, 2022 22:49
@typeofweb typeofweb merged commit 43f78c2 into develop Dec 20, 2022
@typeofweb typeofweb deleted the fix-login-page-styles branch December 20, 2022 23:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants