Skip to content

@types/validator is a production dependency #2583

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
Llois41 opened this issue Feb 21, 2025 · 1 comment · May be fixed by #2584
Open

@types/validator is a production dependency #2583

Llois41 opened this issue Feb 21, 2025 · 1 comment · May be fixed by #2584
Labels
status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature.

Comments

@Llois41
Copy link

Llois41 commented Feb 21, 2025

Description

@types/validator is a production dependency, but it should be a devDependency instead

I submitted a PR. Maybe a maintainer could have a look :)

@Llois41 Llois41 added status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature. labels Feb 21, 2025
@Llois41 Llois41 changed the title fix: <your-title-goes-here> @types/validator is a production dependency Feb 21, 2025
@Llois41 Llois41 linked a pull request Feb 21, 2025 that will close this issue
2 tasks
@braaar
Copy link
Member

braaar commented Mar 4, 2025

I'm thinking there must be a reason why it's listed as a dependency. Without looking into it, I think it's possible that some of the types from there are used in the exported types from this library, meaning that the types are a part of the product, not just something we use during development. This would be different in a non-library project, where typescript types are always just used during development (they don't exist in an actually running javascript program, of course)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature.
Development

Successfully merging a pull request may close this issue.

2 participants