Skip to content
This repository was archived by the owner on Sep 9, 2022. It is now read-only.

document-blocked.html should show filter's origin (filters) #1203

Closed
yfdyh000 opened this issue Apr 7, 2015 · 2 comments
Closed

document-blocked.html should show filter's origin (filters) #1203

yfdyh000 opened this issue Apr 7, 2015 · 2 comments

Comments

@yfdyh000
Copy link

yfdyh000 commented Apr 7, 2015

This warning is shows caused filter, but not show the filter belongs filters, it may be difficult to found it, the users usually enabled a number of filters set, contains tens of thousands of filters.

It should transfer the name of the filters. Transfer the ID might be better, get its name, and allow users to click it to view source (like on Settings interface).

Example: chrome://ublock/content/document-blocked.html?details=eyJ1cmwiOiJodHRwOi8vbHVja3loZWFsaW5nc3RvcmUucnUvIiwiaG4iOiJsdWNreWhlYWxpbmdzdG9yZS5ydSIsIndoeSI6InNiOnx8bHVja3loZWFsaW5nc3RvcmUucnVeIn0=

Relevant code: https://github.com/chrisaljoudi/uBlock/blob/3d382851007b992b109a24f23e7b65e5947aeece/src/js/traffic.js#L220

@chrisaljoudi
Copy link
Contributor

Document blocking is gone in 0.9.3.5. For the moment, it's troublesome and provided little value compared to the frustration it caused.

@2vek
Copy link

2vek commented Apr 19, 2015

@chrisaljoudi Will document blocking be added back in future?
I was using it as sort of productivity tool to block websites like reddit, hn, youtube etc especially on weekdays.

For the time being, I have downgraded back to 0.9.3.0.

EDIT: found an actual valid use case of that feature

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants