Skip to content
This repository has been archived by the owner on May 4, 2021. It is now read-only.

multistage-build: add support for --target option #262

Closed
flixpae opened this issue Sep 16, 2019 · 2 comments · Fixed by #331
Closed

multistage-build: add support for --target option #262

flixpae opened this issue Sep 16, 2019 · 2 comments · Fixed by #331
Labels
enhancement New feature or request

Comments

@flixpae
Copy link

flixpae commented Sep 16, 2019

Is your feature request related to a problem? Please describe.
I try to build a custom ci-builder image to build container images in gitlab-ci on kubernetes

In docker or kaniko a --target option is present.
i would like to control the build target in makisu in a similar way

Describe the solution you'd like
a behaviour close to what the docker documentation describes
https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds

Describe alternatives you've considered
Build with kaniko could work but multistage-builds are tricky and kaniko is not intended to be integrated in a custom image

@yiranwang52 yiranwang52 added the enhancement New feature or request label Sep 16, 2019
@flixpae
Copy link
Author

flixpae commented Oct 11, 2019

Where would i need to look in the code ?
maybe i can look into this a bit further ?

@yiranwang52
Copy link
Contributor

@flixpae you will need to look into lib/builder/build_plan.go

Can you give us an example? I want to understand why using the last stage as target wouldn't work.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants