Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Misleading link on the website #946

Closed
tayabsoomro opened this issue Sep 4, 2018 · 3 comments
Closed

Misleading link on the website #946

tayabsoomro opened this issue Sep 4, 2018 · 3 comments

Comments

@tayabsoomro
Copy link
Contributor

Hi, this is a minor issue that almost got me last night. In the plot showcase page (https://uber.github.io/react-vis/examples/showcases/plots) the view code link for the BarSeries plot is wrong, it leads to line-chart instead of bar-chart, which I had to find by digging into the GitHub repo. See below for more info:

screen shot 2018-09-04 at 8 25 27 am

Thanks,
Tayab Soomro.
@mcnuttandrew
Copy link
Contributor

Thanks for pointing that out! I would welcome a PR if your up for it. I believe the error is somewhere in this file https://github.com/uber/react-vis/blob/master/showcase/showcase-links.js

@tayabsoomro
Copy link
Contributor Author

Definitely! I will create a PR soon. Thanks!

@tayabsoomro tayabsoomro mentioned this issue Sep 4, 2018
Merged
@tayabsoomro
Copy link
Contributor Author

Pulled to master. PR #947. Thanks to @mcnuttandrew 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcnuttandrew @tayabsoomro