Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: switch to akmods repo provided nvidia kmod #146

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

bsherman
Copy link
Contributor

This removes the akmod build process for nvidia drivers and the build of ublue-os-nvidia-addons from this repo, and instead installs said RPMs which are now built in the ublue-os/akmods repo.

Depends on ublue-os/akmods#53

This removes the akmod build process for nvidia drivers and the build
of ublue-os-nvidia-addons from this repo, and instead installs said
RPMs which are now built in the ublue-os/akmods repo.
@bsherman bsherman self-assigned this Aug 25, 2023
@bsherman bsherman requested a review from a team August 25, 2023 03:29
@bsherman bsherman marked this pull request as draft August 25, 2023 03:29
@bsherman
Copy link
Contributor Author

Leaving as a draft until akmods is built and this can test.

@bsherman bsherman marked this pull request as ready for review August 25, 2023 04:22
@bsherman bsherman marked this pull request as draft August 25, 2023 05:16
@bsherman
Copy link
Contributor Author

Ok, at this point, I've tested this by building the silverblue-nvidia image locally, using the already published to ghcr akmods repo containing nvidia 535 kmod, and then pushing the image to a LAN local container registry and rebooting.

Seems to be working pretty well!

Note: we need to update the website repo docs to reflect these changes as the README contents for this repo have been migrated there.

@bsherman bsherman marked this pull request as ready for review August 25, 2023 05:26
@bsherman
Copy link
Contributor Author

I'm not sure why the "Build akmods package" checks are expected, but they can be ignored. I'm hoping they clear after this is merged and a clean build occurs there.

@bsherman bsherman enabled auto-merge August 25, 2023 14:46
@bsherman bsherman disabled auto-merge August 25, 2023 14:46
@bsherman bsherman marked this pull request as draft August 25, 2023 15:08
@bsherman
Copy link
Contributor Author

Marked as draft as @akdev1l and I are discussing some improvements to akmods which may be helpful before merging this.

@bsherman
Copy link
Contributor Author

bsherman commented Aug 25, 2023

Updated: now depends on ublue-os/akmods#54

After the required akmods PR has been merged and built cleanly, this PR needs it's actions re-run to get a clean build.

@bsherman bsherman marked this pull request as ready for review August 25, 2023 19:14
@bsherman bsherman requested a review from EyeCantCU August 25, 2023 20:27
@EyeCantCU EyeCantCU enabled auto-merge August 25, 2023 20:49
@EyeCantCU EyeCantCU disabled auto-merge August 25, 2023 20:53
@EyeCantCU EyeCantCU merged commit 3bdde4c into main Aug 25, 2023
@EyeCantCU EyeCantCU deleted the use-akmods-nvidia branch August 25, 2023 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants