Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UWP HiDPI icon support #5

Closed
lasgor opened this issue Jun 6, 2019 · 1 comment
Closed

UWP HiDPI icon support #5

lasgor opened this issue Jun 6, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@lasgor
Copy link

lasgor commented Jun 6, 2019

Hi, I see Wox launcher supports HiDPI icons for UWP apps:
https://github.com/Wox-launcher/Wox/blob/master/Plugins/Wox.Plugin.Program/Programs/UWP.cs

Perhaps you could implement this as well?

@lasgor lasgor changed the title HiDPI icon support UWP HiDPI icon support Jun 6, 2019
@ueffel ueffel added the enhancement New feature or request label Jun 6, 2019
@ueffel ueffel closed this as completed in 8dc81ea Jul 25, 2019
@ueffel
Copy link
Owner

ueffel commented Jul 25, 2019

For the record, i didn't see any of the windows app icon in wox. They all had the wox default icon. But had a look at the code. Apparently the Square44x44Logo asset size and its scaled versions work best for keypirinha. I thought that bigger asset sizes like Square150x150Logo would make for a better icon, but they just add a lot of unused space around the actual logo. This makes sense when displaying in the start menu as tiles to allow a bit of overlap, but not for the keypirinha icon use case.

So yeah, have a look at the 0.7.0 release. The icons should look better now :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants