Fix location hash being added twice to URL #847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0192877, a fix was made for #747, adding hashes before or after search params in the location service.
This breaks setting URLs with a single hash such as
/home#footer
, which is now being added twice - in the path and the search params like sohome#footer?#footer
I modified an exemplary add to show this behavior: https://stackblitz.com/edit/angular-uirouter-guglw7
The link is generated in
app.component.html
: https://stackblitz.com/edit/angular-uirouter-guglw7?file=src%2Fapp%2Fapp.component.htmlClick on the "Home footer" link to reproduce this error.
I added a fix to ensure the prefixed hash is only added to one of the parts. To the search path, if it exists, or to the url part if it's empty. I also extended the spec for the case of adding a hash without search.
I also added a
test:watch
command to test and watch tests locally which seemed to be missing (npm run watch does not exist as documented in contributing.md). Some additional format changes were made by thehusky
precommit it seems