New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix TypeScript Module Configuration (especially for ESM) #574

Merged

vobu merged 2 commits into ui5-community:main from LukasHeimann:pathModuleConfiguration

Jan 10, 2024

Contributor

LukasHeimann commented Jan 10, 2024

Use correct module/moduleResolution settings: Node16 for esm build, legacy options only for cjs build
Fix a few imports that are now found by typescript, especially around type imports

Compare #573

LukasHeimann added 2 commits

January 10, 2024 13:16


          fix: use correct typescript module settings

dd952df


          fix: clean up imports

50bc7e1

LukasHeimann temporarily deployed to external

January 10, 2024 12:40

— with

GitHub Actions Inactive

vobu approved these changes

View reviewed changes

vobu merged commit 56552d5 into ui5-community:main

13 checks passed

LukasHeimann deleted the pathModuleConfiguration branch

January 10, 2024 13:18

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet