Skip to content

fix: (useCopyToClipboard): copyToClipboard should return promise #313

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kendrickw
Copy link

@kendrickw kendrickw commented Jun 20, 2024

Fixes #312

The copyToClipboard function is not returning a promise currently. The intention (at least according to the function signature) is to fulfill the promise when the text is copied:

usehooks/index.d.ts

Lines 126 to 129 in 90fbbb4

export function useCopyToClipboard(): [
string | null,
(value: string) => Promise<void>
];

This PR will change the code to return a promise. So the promise can fulfill when the text is copied successfully.

@tresorama
Copy link

tresorama commented May 3, 2025

Please merge this.

Currently this other npm lib has a working version:
https://usehooks-ts.com/react-hook/use-copy-to-clipboard

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useCopyToClipboard: copy method not returning promise
2 participants