Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Badge color not working inside active Tab title #276

Closed
arrancardnell opened this issue Mar 14, 2019 · 0 comments
Closed

Badge color not working inside active Tab title #276

arrancardnell opened this issue Mar 14, 2019 · 0 comments
Assignees

Comments

@arrancardnell
Copy link

Version & browser

uiv 0.31.2
Firefox 65.0.2 (64-bit)

Which component

Tab

Steps to reproduce the problem

Using a Tab with html-title and a backstring HTML string as follows:

    <Tab
      html-title
      :title="`<i class='fa fa-fw fa-filter'></i> Filters <span class='badge'>0</span>`"
    >

Expected behavior

Badge inside an active tab should have a white background with tab color text as detailed in the docs here

image

Actual behavior

Badge still has grey background even with active tab.

image

This seems to be because the content of the tab link is wrapped in a span element. Moving the contents out of the span fixes the issue.

@arrancardnell arrancardnell changed the title Badge not working inside Tab title Badge color not working inside active Tab title Mar 14, 2019
@wxsms wxsms added the bug label Mar 21, 2019
@wxsms wxsms self-assigned this Mar 21, 2019
@wxsms wxsms added the finished label Mar 21, 2019
@wxsms wxsms closed this as completed in ad70b3c Mar 21, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants