Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Collapse component does not emit event like bootstrap does. #81

Closed
Tarrask opened this issue Oct 16, 2017 · 1 comment
Closed

Collapse component does not emit event like bootstrap does. #81

Tarrask opened this issue Oct 16, 2017 · 1 comment

Comments

@Tarrask
Copy link
Contributor

Tarrask commented Oct 16, 2017

The collapse bootstrap component emits events when changing it state:

Event Type Description
show.bs.collapse This event fires immediately when the show instance method is called.
shown.bs.collapse This event is fired when a collapse element has been made visible to the user (will wait for CSS transitions to complete).
hide.bs.collapse This event is fired immediately when the hide method has been called.
hidden.bs.collapse This event is fired when a collapse element has been hidden from the user (will wait for CSS transitions to complete).

Can we add them to the Collapse uiv component?

The dot notation of the bootstrap event doesn't work well with the v-on directive, but we can rename them show-collapse, shown-collapse or just show, shown.

I can make a pull request if interested, but I just want to be sure of the event name to use and that is not something implemented in a different way.

@wxsms
Copy link
Member

wxsms commented Oct 16, 2017

Hi.

Thanks for your suggestion. It's not implemented yet. Pull requests are welcome!
As for the event names, show / shown / hide / hidden will be fine, I think.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants