Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update links.yml to --scheme https #43

Merged
merged 4 commits into from
Jan 13, 2024
Merged

Update links.yml to --scheme https #43

merged 4 commits into from
Jan 13, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 13, 2024

Thank you 🙏 for your contribution to Ultralytics 🚀! Your effort in enhancing our repositories is greatly appreciated. To streamline the process and assist us in integrating your Pull Request (PR) effectively, please follow these steps:

  1. Check for Existing Contributions: Before submitting, kindly explore existing PRs to ensure your contribution is unique and complementary.

  2. Link Related Issues: If your PR addresses an open issue, please link it in your submission. This helps us better understand the context and impact of your contribution.

  3. Elaborate Your Changes: Clearly articulate the purpose of your PR. Whether it's a bug fix or a new feature, a detailed description aids in a smoother integration process.

  4. Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:

    I have read the CLA Document and I hereby sign the CLA

For more detailed guidance and best practices on contributing, refer to our ✅ Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced security protocols for link checks in GitHub workflows.

📊 Key Changes

  • Enforced HTTPS usage by adding --scheme 'https' and --require-https flags to lychee link check commands.
  • Modified the wget command options to properly quote the pattern when rejecting file types during downloading, to avoid potential shell globbing.

🎯 Purpose & Impact

  • Purpose: To ensure that link validations are performed over secure connections, increasing the overall security of the automated checks.
  • Impact: Could potentially flag links not using HTTPS, which contributes to a safer browsing experience and adherence to best practices for users. May also prevent any errors or unintended behavior due to unquoted pattern strings in the wget command.

@glenn-jocher glenn-jocher changed the title Update links.yml to reject ? URLs Update links.yml to --scheme https Jan 13, 2024
@glenn-jocher glenn-jocher merged commit f28ee6d into main Jan 13, 2024
4 checks passed
@glenn-jocher glenn-jocher deleted the fix-link-checks branch January 13, 2024 21:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant