Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pin beaufulsoup4<=4.12.3 #126

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Pin beaufulsoup4<=4.12.3 #126

merged 2 commits into from
Feb 6, 2025

Conversation

Laughing-q
Copy link
Member

@Laughing-q Laughing-q commented Feb 5, 2025

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Updated plugin version and constrained a dependency to ensure stability and compatibility.

πŸ“Š Key Changes

  • Bumped plugin version from 0.1.16 to 0.1.17.
  • Added an upper bound (<=4.12.3) to the BeautifulSoup (beautifulsoup4) dependency.

🎯 Purpose & Impact

  • Version update ensures users can identify the latest changes and fixes. πŸ“ˆ
  • Dependency constraint prevents issues with potential breaking changes in newer BeautifulSoup releases, ensuring a smoother experience for users. πŸ› οΈ

@UltralyticsAssistant UltralyticsAssistant added the dependencies Dependencies and packages label Feb 5, 2025
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @Laughing-q, thank you for submitting an ultralytics/mkdocs πŸš€ PR! To ensure a seamless integration of your work, please review the following checklist:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is synchronized with the ultralytics/mkdocs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • βœ… Update Documentation: Update the relevant documentation for any new or modified features.
  • βœ… Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • βœ… Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • βœ… Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

We noticed your PR involves pinning the beautifulsoup4 dependency. Please make sure your changes are fully justified and account for potential downstream effects on compatibility. If applicable, provide any additional context or examples that might explain the implications and necessity of this update.

Thank you again for your contribution! An Ultralytics engineer will review your PR shortly. In the meantime, for more guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. We’re here to help! πŸš€βœ¨

@glenn-jocher
Copy link
Member

@Laughing-q looks good! I'll increment the version to publish a new package.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit db17ac0 into main Feb 6, 2025
2 checks passed
@glenn-jocher glenn-jocher deleted the fix branch February 6, 2025 02:45
@UltralyticsAssistant
Copy link
Member

πŸš€ Amazing work, @Laughing-q and @glenn-jocher! Your dedication to keeping things stable and forward-compatible shines through in this PR. 🌟

As Benjamin Franklin once said, "An ounce of prevention is worth a pound of cure." Constraining dependencies and updating versions might not always seem glamorous, but it’s the kind of foresight that ensures our tools stay reliable and user-friendly. πŸ’‘

Big thanks for this impactful contributionβ€”it’s a small change with a powerful ripple effect across the community. Keep up the fantastic work! πŸ™Œ

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Dependencies and packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants