Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Option to disable v prefix #193

Open
paulmelnikow opened this issue Jul 14, 2023 · 4 comments
Open

Option to disable v prefix #193

paulmelnikow opened this issue Jul 14, 2023 · 4 comments

Comments

@paulmelnikow
Copy link

paulmelnikow commented Jul 14, 2023

Hi! Thanks for this useful tool. Our stack doesn't use v prefixes anywhere, and it would be helpful if I could tell gh-release not to use one.

It seems like it might be possible to work around this using --tag_name, but it's a bit of a gnarly workaround since I'd have to pick the version out of package.json to do that.

It would be nice if you could do something like --without-v-prefix and it would just use what's in the package.json.

Happy to work on this if it's a feature you'd like to see.

@jgravois
Copy link
Collaborator

passing tag_name definitely sounds like the appropriate way to get the customized behavior you're asking for.

i think exposing a way to reference 'version' as a variable in that context would be a lot more useful/flexible than something like --without-v-prefix.

@paulmelnikow
Copy link
Author

i think exposing a way to reference 'version' as a variable in that context would be a lot more useful/flexible

Do you have use cases in mind?

@jgravois
Copy link
Collaborator

not besides yours.

@ungoldman
Copy link
Owner

Considering the prevalence of monorepos and the complex tagging that comes with them (e.g. project-thx-v11.3.8, webapp/1.0.2), it might not be bad to support a --prefix option, default it to v, and in @paulmelnikow's case, allow it to be an empty string. If people deviate from versioning standards even further than that, I wish them the best.

@paulmelnikow if you're willing to go with the implementation described above, a PR is welcome.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants