Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Ravel instance method to Jax Frontend #15388

Merged
merged 3 commits into from
May 18, 2023

Conversation

RakshitKumar04
Copy link
Contributor

No description provided.

@RakshitKumar04
Copy link
Contributor Author

Close #15387

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label May 12, 2023
@RakshitKumar04
Copy link
Contributor Author

Hey @Fayad-Alman please review my PR.

@Fayad-Alman
Copy link
Contributor

@RakshitKumar04 There are conflicts with your branch that you need to resolve. Please update your branch and request another review when you're done making the changes needed.

@RakshitKumar04
Copy link
Contributor Author

Hey, @Fayad-Alman I have resolved the conflicts, Please review the PR.

Copy link
Contributor

@Fayad-Alman Fayad-Alman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, I fixed some lint issues and found that the paddle test doesn't pass, but for now we should be good to merge this. Good work!

@Fayad-Alman Fayad-Alman merged commit a639ea0 into ivy-llc:master May 18, 2023
@RakshitKumar04 RakshitKumar04 deleted the jax-instMeth-ravel branch June 20, 2023 08:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants