Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

HarborAsyncClient is too verbose of a name #64

Open
pederhan opened this issue Oct 13, 2023 · 0 comments
Open

HarborAsyncClient is too verbose of a name #64

pederhan opened this issue Oct 13, 2023 · 0 comments

Comments

@pederhan
Copy link
Member

pederhan commented Oct 13, 2023

The name HarborAsyncClient is technically correct, but is incredibly verbose. As this package is async-first, having Async in the class name seems superfluous. While we can't get rid of this name entirely because of backwards-compatibility, we can introduce a new alias that can be imported instead.

Some suggestions:

  • Harbor
  • HarborAPI
  • HarborClient
    • In this case we need to break backwards-compatibility with imports of harbor.HarborClient, which currently is a shorthand for harbor.client_sync.HarborClient, and then rename the existing one to harbor.client_sync.HarborSyncClient.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant