Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(findExports): support multiple exports terminated with ; #72

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #72 (d0b5749) into main (d760c97) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   58.15%   58.19%   +0.04%     
==========================================
  Files          13       13              
  Lines        2196     2196              
  Branches      233      232       -1     
==========================================
+ Hits         1277     1278       +1     
  Misses        695      695              
+ Partials      224      223       -1     
Impacted Files Coverage Δ
src/analyze.ts 79.14% <100.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix(exports): regex should terminate on ; fix(exports): support multiple exports terminated with ; Aug 22, 2022
@pi0 pi0 changed the title fix(exports): support multiple exports terminated with ; fix(findExports): support multiple exports terminated with ; Aug 22, 2022
@pi0
Copy link
Member

pi0 commented Aug 22, 2022

Thanks! Would you mind checking if we would also need this for imports?

@pi0 pi0 merged commit e7a8de3 into main Aug 22, 2022
@pi0 pi0 deleted the feat/export-regex-inline branch August 22, 2022 09:02
@antfu
Copy link
Member Author

antfu commented Aug 23, 2022

Yes imports have been covered

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants