Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(findExports): extract multi line named exports #75

Merged
merged 2 commits into from
Sep 19, 2022
Merged

fix(findExports): extract multi line named exports #75

merged 2 commits into from
Sep 19, 2022

Conversation

liuyang0826
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #75 (0e563f6) into main (554f927) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files          13       13           
  Lines        2196     2196           
  Branches      232      233    +1     
=======================================
  Hits         1482     1482           
  Misses        695      695           
  Partials       19       19           
Impacted Files Coverage Δ
src/analyze.ts 97.63% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we could fix this by improving named export parser regex but seems also good solution 👍🏼 /cc @danielroe

@pi0 pi0 changed the title fix(findExports): works with line feed fix(findExports): extract multi line named exports Sep 19, 2022
@pi0 pi0 merged commit e22ead6 into unjs:main Sep 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants