Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Refactoring of the code base #5

Closed
bharathkalyans opened this issue Sep 11, 2023 · 4 comments
Closed

refactor: Refactoring of the code base #5

bharathkalyans opened this issue Sep 11, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bharathkalyans
Copy link
Contributor

  • Codebase contains a lot of warnings and redundant code.
    Eg.The below code can have a private constructor, so an object can't be created.
public class Constants {
    public static final String AGENT_VERSION = "1.0.1";
}
@bharathkalyans
Copy link
Contributor Author

@artpar I would love to work on this!!
Can you assign this to me?

@artpar
Copy link
Contributor

artpar commented Sep 11, 2023

@bharathkalyans Thanks for the PR.

Changes which rearrange the keywords and reformat the code are something which I don't want to accept at this point.

This leaves the 3 changes,

  • Contants.java private constructor
  • fixing of the comment in Unlogged.java
  • ClassTypeUtil.java private constructor

They look fine and I can merge them if you can remove the formatting changes.

@artpar artpar added enhancement New feature or request good first issue Good for newcomers labels Sep 11, 2023
@bharathkalyans
Copy link
Contributor Author

@artpar New PR fix the requirements? Would you like me to fix anything else?

@artpar
Copy link
Contributor

artpar commented Sep 13, 2023

Merged. Thanks @bharathkalyans

@artpar artpar closed this as completed Sep 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants