Move linting into ink repo #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
requested review from
a team,
cmichi,
ascjones and
HCastano
as code owners
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑
These are the results when building the
Link to the run | Last update: Tue Aug 23 21:25:12 CEST 2022 |
alvicsam
reviewed
Aug 23, 2022
alvicsam
reviewed
Aug 23, 2022
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1361 +/- ##
=======================================
Coverage 71.96% 71.96%
=======================================
Files 177 177
Lines 5928 5928
=======================================
Hits 4266 4266
Misses 1662 1662 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HCastano
approved these changes
Aug 23, 2022
| [package.metadata.rust-analyzer] | ||
| rustc_private = true | ||
|
|
||
| [workspace] |
There was a problem hiding this comment.
Yes. The driver does not build without that. All the examples in the dylint repo have this, too.
| This crate uses [`dylint`](https://github.com/trailofbits/dylint) to define custom | ||
| linting rules for [ink!](https://github.com/paritytech/ink); | ||
|
|
||
| It is not part of the workspace because it needs a custom linker to be built. |
There was a problem hiding this comment.
I was about to ask if we could include this in the ink! workspace, haha
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
cmichi
pushed a commit
that referenced
this pull request
Aug 31, 2022
* Move linting into ink repo * Fix CI * Apply suggestions from code review Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> * Update .gitlab-ci.yml Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> * Update linting/Cargo.toml Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Update linting/Cargo.toml Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
xermicus
pushed a commit
that referenced
this pull request
Sep 8, 2022
* Move linting into ink repo * Fix CI * Apply suggestions from code review Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> * Update .gitlab-ci.yml Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> * Update linting/Cargo.toml Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Update linting/Cargo.toml Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com> Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the changes to
cargo contractwhich will make the lints being build as part of the contract build we move it here. The lints are tightly coupled to the ink! code. There is no reason why they should exist in thecargo contractrepo.