-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement cross-contract testing in E2E framework #1432
Conversation
Executed for `substrate-contracts-node` v0.21.0: cargo install subxt-cli subxt metadata > contracts-node.scale
Same issue as use-ink/cargo-contract#777.
3acea90
to
66f5d2d
Compare
I had to remove `skip_build` as keeping it work would become too complex right now. Will create a follow-up ticket for it.
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
- Coverage 70.89% 70.63% -0.27%
==========================================
Files 193 194 +1
Lines 6071 6095 +24
==========================================
+ Hits 4304 4305 +1
- Misses 1767 1790 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
.args([ | ||
"+stable", | ||
"contract", | ||
"build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we control cargo-contract
it might be really nice to have a lib to allow invocation of contract builds...would certainly simplify the code here.
Made a quick start on it here use-ink/cargo-contract#787.
If you agree it is a good idea I can complete that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's a good idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we de-dup the metadata? Maybe just a soft link.
Needed for #1234.
Can be reviewed commit-by-commit, though the PR is also not that big in total.