Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement cross-contract testing in E2E framework #1432

Merged
merged 13 commits into from
Oct 19, 2022

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Oct 11, 2022

Needed for #1234.

Can be reviewed commit-by-commit, though the PR is also not that big in total.

@cmichi cmichi force-pushed the cmichi-e2e-cross-contract-oct-08 branch from 3acea90 to 66f5d2d Compare October 11, 2022 16:15
I had to remove `skip_build` as keeping it work would
become too complex right now. Will create a follow-up
ticket for it.
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #1432 (ca5a062) into master (4156112) will decrease coverage by 0.26%.
The diff coverage is 17.33%.

@@            Coverage Diff             @@
##           master    #1432      +/-   ##
==========================================
- Coverage   70.89%   70.63%   -0.27%     
==========================================
  Files         193      194       +1     
  Lines        6071     6095      +24     
==========================================
+ Hits         4304     4305       +1     
- Misses       1767     1790      +23     
Impacted Files Coverage Δ
crates/e2e/macro/src/codegen.rs 0.00% <0.00%> (ø)
crates/e2e/macro/src/lib.rs 0.00% <ø> (ø)
crates/e2e/src/lib.rs 0.00% <ø> (ø)
crates/e2e/src/utils.rs 0.00% <0.00%> (ø)
crates/e2e/src/xts.rs 0.00% <0.00%> (ø)
crates/e2e/macro/src/config.rs 50.00% <81.25%> (+4.34%) ⬆️
crates/metadata/src/layout/mod.rs 75.63% <0.00%> (-1.69%) ⬇️
crates/ink/ir/src/ir/attrs.rs 81.99% <0.00%> (-0.28%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmichi cmichi marked this pull request as ready for review October 12, 2022 10:33
@cmichi cmichi requested review from SkymanOne and athei October 12, 2022 10:33
.args([
"+stable",
"contract",
"build",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we control cargo-contract it might be really nice to have a lib to allow invocation of contract builds...would certainly simplify the code here.

Made a quick start on it here use-ink/cargo-contract#787.

If you agree it is a good idea I can complete that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's a good idea!

Copy link
Contributor

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we de-dup the metadata? Maybe just a soft link.

@cmichi cmichi merged commit 4f0c88b into master Oct 19, 2022
@cmichi cmichi deleted the cmichi-e2e-cross-contract-oct-08 branch October 19, 2022 10:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants