Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove node log testing from E2E framework #1443

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Oct 20, 2022

Removing the node_log_contains command for the reasons outlined in #1423.

@cmichi cmichi requested a review from SkymanOne October 20, 2022 05:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #1443 (992f34d) into master (4f0c88b) will decrease coverage by 7.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
- Coverage   70.64%   63.43%   -7.22%     
==========================================
  Files         194      194              
  Lines        6095     6080      -15     
==========================================
- Hits         4306     3857     -449     
- Misses       1789     2223     +434     
Impacted Files Coverage Δ
crates/e2e/macro/src/codegen.rs 0.00% <ø> (ø)
crates/e2e/macro/src/lib.rs 0.00% <ø> (ø)
crates/e2e/macro/src/config.rs 57.89% <100.00%> (+7.89%) ⬆️
crates/ink/ir/src/ir/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/ink/ir/src/ir/ink_test.rs 0.00% <0.00%> (-87.50%) ⬇️
crates/ink/ir/src/ir/trait_def/mod.rs 0.00% <0.00%> (-83.34%) ⬇️
crates/ink/ir/src/ir/storage_item/config.rs 0.00% <0.00%> (-73.34%) ⬇️
crates/ink/ir/src/ir/storage_item/mod.rs 0.00% <0.00%> (-72.35%) ⬇️
crates/ink/ir/src/ir/blake2.rs 20.00% <0.00%> (-60.00%) ⬇️
crates/ink/ir/src/ir/trait_def/config.rs 7.14% <0.00%> (-57.15%) ⬇️
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in the linked issue, this can possibly be replaced by asserting the debug buffer from the RPC dry run result.

@cmichi cmichi merged commit c083c8c into master Oct 20, 2022
@cmichi cmichi deleted the cmichi-remove-node-log-testing-from-e2e-framework branch October 20, 2022 13:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants