Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add types #470

Closed
Shahaed opened this issue Jun 22, 2020 · 3 comments
Closed

Add types #470

Shahaed opened this issue Jun 22, 2020 · 3 comments

Comments

@Shahaed
Copy link

Shahaed commented Jun 22, 2020

Add types for this package. Simple type definition already exists: https://www.npmjs.com/package/@types/uuid. Incorporating it into this repo would be really helpful.

@ctavan
Copy link
Member

ctavan commented Jun 22, 2020

This has been discussed in the past but as long as this library is written in JavaScript we're going to continue to publish the types as a separate package, see #368 (comment)

In fact the maintainers of uuid are maintaining @types/uuid as well!

@ctavan ctavan closed this as completed Jun 22, 2020
@Shahaed
Copy link
Author

Shahaed commented Jun 22, 2020

Most other popular npm packages include types in the same package and saves typescript users from having to import 2 packages. Also makes maintenance easier.

My vote would be including types in the same package, but it's y'all decision.

@ctavan
Copy link
Member

ctavan commented Jun 22, 2020

Feel free to raise this issue over at TypeScript. If TypeScript decides to change their recommendations, I'll be happy to follow whatever the official recommendations are.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants