Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ls: " is not taken in consideration when building table #3584

Closed
AndreasBrostrom opened this issue Jun 1, 2022 · 8 comments · Fixed by #3590
Closed

ls: " is not taken in consideration when building table #3584

AndreasBrostrom opened this issue Jun 1, 2022 · 8 comments · Fixed by #3590

Comments

@AndreasBrostrom
Copy link

image

$ coreutils --help
coreutils 0.0.14 (multi-call binary)
$ echo $SHELL
/bin/fish
~ 
$ cat .config/fish/conf.d/00_aliases.fish
alias ls='ls --color=auto'
alias ll='ls -alF'
alias lsl='ls -lF'
alias la='ls -A'
alias lsa='la'
alias l='ls -CF'
alias lr='ls -ltrh'
alias lra='ls -ltrha'
alias dir='dir --color=auto'
alias dir='ls -l'
alias vdir='vdir --color=auto'
@tertsdiepraam
Copy link
Member

tertsdiepraam commented Jun 1, 2022

This is due to locale, which influences the sorting order. We follow the C locale in all sorting at the moment. Recently, work has started on a Unicode collator (read: sorter) has started in the ICU4X project. My hope is that we can use that to fix the sorting in the near future.

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Jun 1, 2022

Here is where this was originally discussed: #2149

@AndreasBrostrom
Copy link
Author

Ignoring the sorting then in this thread
symbol " is not taken in consideration.

@AndreasBrostrom AndreasBrostrom changed the title ls: Odd sorting and " is not taken in consideration when building table ls: " is not taken in consideration when building table Jun 1, 2022
@tertsdiepraam
Copy link
Member

Yeah, that's indeed something we should fix. What's going on with the '.moonchild productions' folder? Does it have quotes in the name and then GNU doesn't quote it, but we do quote it with an additional "? (This is apart from the spacing that is messed up)

@AndreasBrostrom
Copy link
Author

AndreasBrostrom commented Jun 2, 2022

No its just named .moonchild productions the rebuild add both "'.moonchild productions'" while GNU add just '.moonchild productions'

@tertsdiepraam
Copy link
Member

Oof that's bad hahahaha. Thanks for the report!

@tertsdiepraam
Copy link
Member

The linked PR should fix this issue. Feel free to test it out and provide feedback! Note that this is not yet entirely compatible with GNU, because GNU inserts an additional space for all non-quoted names if any name is quoted, but at least it is not double quoted and nicely lined up.

@AndreasBrostrom
Copy link
Author

Works fine!
image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants